-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DASH UrlTemplate parses template if it contains more than one time ea… #574
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello @hugohlln, Thank you for looking to contribute to ExoPlayer. Before we review your Pull Request, you'll need to sign the Contributor License Agreement (CLA). Thank you! |
Hi @microkatz, Thanks for yout reply. Sorry, it's done |
@hugohlln thanks for the fix, will be very helpful. |
@hugohlln Wonderful fix this will help my team and allow us to continue working with exoPlayer |
QA will need this, i'm currently struggling with using a proxy with the exoplayer this fix will be very helpful! Thanks @hugohlln |
libraries/exoplayer_dash/src/main/java/androidx/media3/exoplayer/dash/manifest/UrlTemplate.java
Outdated
Show resolved
Hide resolved
Thanks for your reply. I've just added tests in UrlTemplateTest and also changed the regex to match identifiers with escaped dollars. All tests are sucessfully running |
libraries/exoplayer_dash/src/main/java/androidx/media3/exoplayer/dash/manifest/UrlTemplate.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_dash/src/main/java/androidx/media3/exoplayer/dash/manifest/UrlTemplate.java
Outdated
Show resolved
Hide resolved
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
PiperOrigin-RevId: 570037211 (cherry picked from commit b06d823)
With DASH, it's possible to have multiple times each DASH identifier in a template (for example by using a proxy, see Chaos streaming proxy).
This commit allows to compile templates containing more than 4 identifiers (it was not possible before)