Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Format.Builder documentation #1823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Format.Builder documentation #1823

wants to merge 1 commit into from

Conversation

MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Oct 23, 2024 •
edited
Loading

This PR fixes the documentation for Format.Builder.setTileCountHorizontal and Format.Builder.setTileCountVertical.

@icbaker
Copy link
Collaborator

icbaker commented Oct 23, 2024

I think we still want to avoid touching the API checks in the session.legacy package for the same reason outlined here: #1549 (comment)

@MGaetan89
Copy link
Contributor Author

Oh, I forgot about that, sorry.
I will revert that change

@MGaetan89 MGaetan89 changed the title Remove outdated SDK check Fix Format documentation Oct 23, 2024
@MGaetan89
Copy link
Contributor Author

Oh, I forgot about that, sorry. I will revert that change

Done. Now the PR only fixed the documentation for a couple of Format.Builder methods.

@MGaetan89 MGaetan89 changed the title Fix Format documentation Fix Format.Builder documentation Oct 23, 2024
@MGaetan89 MGaetan89 force-pushed the remove_outdated_sdk_check branch 3 times, most recently from 7558250 to 445fc44 Compare October 29, 2024 10:13
@MGaetan89 MGaetan89 force-pushed the remove_outdated_sdk_check branch 2 times, most recently from 1114179 to ceeab99 Compare November 6, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @icbaker