-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEA-708: Update current row value when new line is added #1315
CEA-708: Update current row value when new line is added #1315
Conversation
Ah it looks like we previously merged the I think 'Fix 2' in this PR wasn't part of #942 - so maybe you could update this PR to only contain 'Fix 2'? |
Thanks, I've updated the PR title and the code changes to reflect the fix for fix 2 only. |
I've re-applied the |
This change was originally made in 379cb3b. It was then accidentally lost in when `Cea608Parser` was merged back into `Cea608Decoder` in 25498b1. This was spotted when re-doing a similar lost change to `Cea708Decoder`, reported in #1315. See reasoning on e2847b3 about why this is the only 'lost' CEA-608 change. PiperOrigin-RevId: 635803536
Would you be able to provide a bit more info about this? Even better if you can craft a test case that demonstrates the issue that is fixed by this change. In particular I'm trying to understand how this interacts with the existing |
I've added a couple of test related to newline handling and setPenLocation. Essentially, without the fix, we get an extra newline in the output. |
2f96dc0
to
8eda764
Compare
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
8eda764
to
e87b820
Compare
Update current row value when new line is added. This is to prevent an incorrect newline to be added in setPenLocation.