CEA-608 captions in DASH disappear almost immediately #904
Assignees
Labels
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Dec 19, 2023
We deliberately left `Cea608Decoder` and `Cea708Decoder` intact when creating the respective `SubtitleParser` implementations (in 27caeb8 and 94e45eb respectively). However we didn't correctly change the behaviour of `SubtitleDecoderFactory.DEFAULT` in order to use these 'legacy' implementations. We firstly left the `Cea608Decoder` instantiation **after** the `DefaultSubtitleParserFactory.supportsFormat()` check, meaning that code would never be reached (since `supportsFormat` now returns true for CEA-608). Then in the second change (which was supposed to only be about CEA-708) we removed all instantiations of **both** `Cea608Decoder` and `Cea708Decoder`. This change puts the decoder instantiations back and moves them above the `DefaultSubtitleParserFactory.supportsFormat` check, meaning they will be used in preference to `DelegatingSubtitleDecoder`. This resolves the immediately-disappearing subtitles tracked by Issue: #904. PiperOrigin-RevId: 592217937
copybara-service bot
pushed a commit
to google/ExoPlayer
that referenced
this issue
Dec 19, 2023
We deliberately left `Cea608Decoder` and `Cea708Decoder` intact when creating the respective `SubtitleParser` implementations (in 764a85e and c3cda76 respectively). However we didn't correctly change the behaviour of `SubtitleDecoderFactory.DEFAULT` in order to use these 'legacy' implementations. We firstly left the `Cea608Decoder` instantiation **after** the `DefaultSubtitleParserFactory.supportsFormat()` check, meaning that code would never be reached (since `supportsFormat` now returns true for CEA-608). Then in the second change (which was supposed to only be about CEA-708) we removed all instantiations of **both** `Cea608Decoder` and `Cea708Decoder`. This change puts the decoder instantiations back and moves them above the `DefaultSubtitleParserFactory.supportsFormat` check, meaning they will be used in preference to `DelegatingSubtitleDecoder`. This resolves the immediately-disappearing subtitles tracked by Issue: androidx/media#904. PiperOrigin-RevId: 592217937
copybara-service bot
pushed a commit
to google/ExoPlayer
that referenced
this issue
Dec 19, 2023
This would have immediately exposed the mistakes fixed by 4893d9b Issue: androidx/media#904 PiperOrigin-RevId: 592244943
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
Media3
mainbranchMore version details
b7c3d83
Devices that reproduce the issue
Pixel 7a
Devices that do not reproduce the issue
None
Reproducible in the demo app?
Yes
Reproduction steps
Expected result
Subtitles appear and disappear in sync with the audio
Actual result
Subtitles appear on screen and almost immediately disappear again, making them completely unreadable.
This behaviour doesn't happen on 1.2.0 so this seems to be a recent regression.
Media
Shared via email as part of #887
Bug Report
adb bugreportto [email protected] after filing this issue.The text was updated successfully, but these errors were encountered: