Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build demo-transformer due to missing CompositionPlayer in CompositionPreviewActivity #741

Closed
1 task
kolyneh opened this issue Oct 19, 2023 · 4 comments
Closed
1 task

Can't build demo-transformer due to missing CompositionPlayer in CompositionPreviewActivity #741

kolyneh opened this issue Oct 19, 2023 · 4 comments
Assignees
@droid-girl
Labels
bug

Comments

@kolyneh
Copy link

kolyneh commented Oct 19, 2023

Version

Media3 main branch

More version details

No response

Devices that reproduce the issue

All devices.

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

Run the demo: demo-transformer .

Expected result

Provide androidx.media3.transformer.CompositionPlayer.

Actual result

In CompositionPreviewActivity we can't import androidx.media3.transformer.CompositionPlayer since it's missing.

If CompositionPlayer is ready to be imported then make it public.

Media

Not applicable

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@droid-girl
Copy link
Contributor

The fix is already on the way

@droid-girl
Copy link
Contributor

In the meantime, you could comment out CompositionPreviewActivity from the Manifest file and comment out the content of CompositionPreviewActivity. It should allow you to compile the demo app

@kolyneh
Copy link
Author

kolyneh commented Oct 19, 2023

Thanks.

copybara-service bot pushed a commit that referenced this issue Oct 19, 2023
@droid-girl @copybara-github
Remove CompositionPlayer activity from the transformer demo app
beb1711 
The CompositionPlayer is not ready yet.

Issue: #741
PiperOrigin-RevId: 574859927
copybara-service bot pushed a commit to google/ExoPlayer that referenced this issue Oct 19, 2023
@droid-girl @copybara-github
Remove CompositionPlayer activity from the transformer demo app
952a589 
The CompositionPlayer is not ready yet.

Issue: androidx/media#741
PiperOrigin-RevId: 574859927
@droid-girl
Copy link
Contributor

Should be fixed now with the latest commit. Thank you for reporting the issue

rohitjoins pushed a commit that referenced this issue Oct 23, 2023
@droid-girl @rohitjoins
Remove CompositionPlayer activity from the transformer demo app
4e3dbc4 
The CompositionPlayer is not ready yet.

Issue: #741
PiperOrigin-RevId: 574859927
(cherry picked from commit beb1711)
rohitjoins pushed a commit that referenced this issue Oct 24, 2023
@droid-girl @rohitjoins
Remove CompositionPlayer activity from the transformer demo app
9ac6f89 
The CompositionPlayer is not ready yet.

Issue: #741
PiperOrigin-RevId: 574859927
(cherry picked from commit beb1711)
@androidx androidx locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@droid-girl droid-girl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@droid-girl @kolyneh