-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggling skip silence breaks the output #712
Labels
Comments
Hi @JureSencar, Thanks for reporting! I can reproduce this issue even on ExoPlayer 2.19.0, while 2.18.7 is not reproducible. @tonihei I feel that the commit google/ExoPlayer@3d82846 is suspicious, would it be possible that this commit causes the issue here? |
naveensingh
added a commit
to FossifyOrg/Music-Player
that referenced
this issue
Oct 17, 2023
Enable when androidx/media#712 is resolved. See SimpleMobileTools/Simple-Music-Player#604
copybara-service bot
pushed a commit
that referenced
this issue
Dec 11, 2023
Issue: #712 PiperOrigin-RevId: 589882412
copybara-service bot
pushed a commit
to google/ExoPlayer
that referenced
this issue
Dec 11, 2023
Issue: androidx/media#712 PiperOrigin-RevId: 589882412
Hi @JureSencar, the fix is in the main branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
Media3 1.1.1
This did not happen in ExoPlayer 2.18.7 library.
Devices that reproduce the issue
Pixel 6a Android 13
Reproducible in the demo app?
Yes
Reproduction steps
In PlayerActivity replace the body in
onClick
withThen open and play any file (e.g.
Google Play (MP3)
).Press the button a few times. Sometimes it is enough to just turn it on and off, sometimes it takes a few clicks.
Expected result
The media continues playing normally with the latest skipSilenceEnabled applied.
Actual result
The sound at the output gets corrupted until a user performs seek operation.
Media
This seems to be independent from the container and source type (stream or local file).
The text was updated successfully, but these errors were encountered: