-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PlayerControlView work as a standalone component #514
Comments
I don't believe it's related to #511 For the following reasons:
|
Sorry to hear that you couldn't find all the information you needed. Would you mind listing some of the topics that were hard to find help for? We'd really like to improve documentation where needed.
Based on your description, it sounds like something in the media structure or available commands is changing that causes this problem. After the buttons disappear again, can you log the value of And for more context:
That shouldn't make a difference because the code for this UI module is exactly the same. The only catch is that we renamed |
mediaController.isCommandAvailable( COMMAND_SEEK_TO_PREVIOUS_MEDIA_ITEM ); = false I have a list of live steams loaded. Having read your post, I have changed my code to use PlayerView, and i'm seeing the next/previous controls. I guess that gives me something to start looking into. As for documentation, I will go back and make a list of specifics, one of the key items is the lack of Java documentation, where the new Kotlin language is very dominant. |
What are values of
That's actually a relatively strong signal that you may have seen the "minimal mode" I was mentioning. If you want to know for certain, you could check with a debugger what the value of |
Many Thanks, Confirmed, playerControlView.controlViewLayoutManager.isMinimalMode is true. What's odd, there is plenty of layout space for the controls. Is there a suggestion on how to fix this? I can't see anything in the PlayerControlView to set if minimal mode is used. |
@icbaker Do you know if there is an existing issue that tracks the enhancement for "Allow stand-alone usage of PlayerControlView"? This keeps coming up as a request and we should probably use one issue to track this even if we can't fully support a stand-alone version soon. And second question - do you think it's useful to have a setter that disables minimal mode entirely? The code in |
Let's repurpose this one.
When I looked into this before it was in the context of a |
@tonihei Regarding the documentation aspects. The main issues are are around Android Auto, as the documentation there isn't using Media3. You end up following a set of documents that do things one way, then you end up at a dead end, and follow other docs that do things differently. Nothing ever links up. The code samples are a similar problem, so apps support some aspects of media playback and do things in one way, the other same apps do things differently. The migration guide has alot of gaps. Layer on top that everything is now Kotlin, trying to make sense of the docs. Would be good to get a single set of documentation that includes Media3, Android Auto, Media Search. |
Thanks for the feedback - we are actively working on our documentation and the issues you describe will likely be covered by a single guide page. |
Porting my app from ExoPlayer to Media3, and have struggled around most of the gaps in the information, and finally have something that works.
I'm down to my last issue to fix, specifically that the next/previous track buttons aren't showing in PlayerControlView. They are showing everywhere else:
Given all this, I think would usually assume the player is being build correctly, and it's something else, however, I briefly see the next/prev controls, when the activity loads, until the the player gets connected, then they disappear.,
I did a bit of debugging, and calling hasNextMediaItem() returns true, as does hasPreviousMediaItem() when I ask my mediacontroller if it's got things to play in the list.
I have tried all the usual things like forcing it to show using setShowPreviousButton(true); and setShowNextButton(true); and also setting this in the XML, this also didn't work.
I have tried stripping my player back to the basics, with none of the fancy stuff, still no joy. I'm not doing anything fancy, just a list of MediaItem of audio streams.
I'm now thinking about going back to Exoplayer, and parking Media3, as i've run out of ideas. Hoping someone here might have some ideas on what to look at next.
The text was updated successfully, but these errors were encountered: