Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoplayer2 in media3 #476

Closed
giladna opened this issue Jun 24, 2023 · 1 comment
Closed

exoplayer2 in media3 #476

giladna opened this issue Jun 24, 2023 · 1 comment
Assignees
Labels

Comments

@giladna
Copy link

giladna commented Jun 24, 2023

hi team

I was thinking you might be interested in updating this line:

private static String buildCustomDiagnosticInfo(int errorCode) {
      String sign = errorCode < 0 ? "neg_" : "";
      return "com.google.android.exoplayer2.mediacodec.MediaCodecRenderer_"
          + sign
          + Math.abs(errorCode);
    }
  }

return "com.google.android.exoplayer2.mediacodec.MediaCodecRenderer_"

@tianyif
Copy link
Contributor

tianyif commented Jun 26, 2023

Thanks a lot for the reporting! We will make a change on this.

tianyif added a commit that referenced this issue Jun 30, 2023
Issue: #476

#minor-release

PiperOrigin-RevId: 543460075
tianyif added a commit to google/ExoPlayer that referenced this issue Jun 30, 2023
@tianyif tianyif closed this as completed Jun 30, 2023
tianyif added a commit to google/ExoPlayer that referenced this issue Aug 11, 2023
Issue: androidx/media#476

#minor-release

PiperOrigin-RevId: 543460075
(cherry picked from commit 5584007)
tianyif added a commit that referenced this issue Aug 14, 2023
Issue: #476

#minor-release

PiperOrigin-RevId: 543460075
(cherry picked from commit 140c83c)
tianyif added a commit to google/ExoPlayer that referenced this issue Aug 14, 2023
Issue: androidx/media#476

#minor-release

PiperOrigin-RevId: 543460075
(cherry picked from commit 5584007)
@androidx androidx locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants