Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCD data as query parameter is url-encoded twice #1075

Closed
1 task
sobbe81 opened this issue Feb 7, 2024 · 1 comment
Closed
1 task

CMCD data as query parameter is url-encoded twice #1075

sobbe81 opened this issue Feb 7, 2024 · 1 comment
Assignees
@icbaker
Labels
bug

Comments

@sobbe81
Copy link

sobbe81 commented Feb 7, 2024

Version

Media3 1.2.1

More version details

No response

Devices that reproduce the issue

All devices

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Enable CMCD as query-parameter
  2. Play something

Expected result

CMCD data included in the url as query-parameters and url-encoded

Actual result

This is an example of a CMCD query-parameter.

CMCD=bl%253D20200%252Cbr%253D6000%252Cd%253D3840%252Cdl%253D20200%252Cmtp%253D57500%252Cot%253Dv%252Csf%253Dd%252Cst%253Dl%252Ctb%253D6000

Is seems like it's url-encoded twice. Is that done intentially?

Media

N/A

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@icbaker icbaker self-assigned this Feb 7, 2024
@icbaker
Copy link
Collaborator

icbaker commented Feb 7, 2024

Thanks for spotting, I can reproduce this behaviour, I'll send a fix for review.

copybara-service bot pushed a commit that referenced this issue Feb 7, 2024
@icbaker @copybara-github
Stop double-encoding CMCD query parameters
7ebfed5 
`Uri.appendQueryParameter` is documented to encode its arguments, so
calling `Uri.encode` beforehand results in double-encoding.

Issue: #1075

#minor-release

PiperOrigin-RevId: 604995441
copybara-service bot pushed a commit to google/ExoPlayer that referenced this issue Feb 7, 2024
@icbaker @copybara-github
Stop double-encoding CMCD query parameters
b3a5587 
`Uri.appendQueryParameter` is documented to encode its arguments, so
calling `Uri.encode` beforehand results in double-encoding.

Issue: androidx/media#1075

#minor-release

PiperOrigin-RevId: 604995441
@icbaker icbaker closed this as completed Feb 8, 2024
SheenaChhabra pushed a commit that referenced this issue Feb 9, 2024
@icbaker @SheenaChhabra
Stop double-encoding CMCD query parameters
1dc4377 
`Uri.appendQueryParameter` is documented to encode its arguments, so
calling `Uri.encode` beforehand results in double-encoding.

Issue: #1075

#minor-release

PiperOrigin-RevId: 604995441
(cherry picked from commit 7ebfed5)
@androidx androidx locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@icbaker icbaker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icbaker @sobbe81