Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Refactor out MotionLayout.kt classes #616

Merged
merged 1 commit into from
May 26, 2022

Conversation

oscar-ad
Copy link
Collaborator

This refactors the following classes into separate files (with their
respective interfaces, helper functions):

  • Transition.kt: Transition, (Composable) Transition, TransitionImpl
  • MotionScene.kt: MotionScene, (Composable) MotionScene, JSONMotionScene
  • MotionMeasurer.kt: MotionMeasurer

Applied formatting rest of package

This refactors the following classes into separate files (with their
respective interfaces, helper functions):
- Transition.kt: Transition, (Composable) Transition, TransitionImpl
- MotionScene.kt: MotionScene, (Composable) MotionScene, JSONMotionScene
- MotionMeasurer.kt: MotionMeasurer

Applied formatting rest of package
@oscar-ad oscar-ad requested review from jafu888 and jswong65 May 25, 2022 22:25
Copy link
Collaborator

@jswong65 jswong65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscar-ad oscar-ad merged commit c4e3472 into androidx:main May 26, 2022
@oscar-ad oscar-ad deleted the motionCleanup branch May 26, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants