Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Compose text snippets #210

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Add new Compose text snippets #210

merged 4 commits into from
Feb 8, 2024

Conversation

bentrengrove
Copy link
Member

No description provided.

Copy link

snippet-bot bot commented Feb 7, 2024

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one comment about whether or not TextSample should be included

@@ -577,7 +591,188 @@ private object TextEffectiveStateManagement2 {
// [END android_compose_text_state_management]
}

private val firaSansFamily = FontFamily()
@Composable
private fun TextSample(samples: Map<String, @Composable ()->Unit>) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This composable used in the snippets below - did you want to include a region tag for these as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left it out deliberately. The screenshots in the doc include labels to show which text paragraph is which because its not super obvious, but then the code snippet wouldn't match the screenshot. I made this as kind of a middle ground where people could click into the snippet to see how it was generated but the code snippet in DAC was still just the relevant code.

@bentrengrove bentrengrove merged commit 2800143 into main Feb 8, 2024
4 checks passed
@bentrengrove bentrengrove deleted the ben/text branch February 8, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants