Add snippets for Indication and Ripple migration #191

arriolac · 2024-01-24T18:35:52Z

Merging this against latest branch which uses the latest Compose versions so that main continues to use the latest stable version.

snippet-bot · 2024-01-24T18:35:57Z

Here is the summary of changes.

You are about to add 29 region tags.

compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:89, tag android_compose_interactions_interaction_state
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:102, tag android_compose_interactions_interaction_source_input
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:110, tag android_compose_interactions_mutable_interaction_source_input
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:118, tag android_compose_interactions_high_level_component
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:139, tag android_compose_interactions_hoverable
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:156, tag android_compose_interactions_focusable
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:174, tag android_compose_interactions_clickable
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:196, tag android_compose_interactions_flow_apis
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:217, tag android_compose_interactions_add_remove
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:247, tag android_compose_interactions_is_pressed_or_dragged
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:251, tag android_compose_interactions_last
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:262, tag android_compose_interactions_batched
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:272, tag android_compose_interactions_press_icon_button
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:303, tag android_compose_interactions_press_icon_button_usage
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:314, tag android_compose_interactions_indication
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:329, tag android_compose_interactions_scale_node
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:368, tag android_compose_interactions_scale_node_factory
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:381, tag android_compose_interactions_button_indication
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:398, tag android_compose_interactions_scale_button
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:428, tag android_compose_interactions_scale_button_example
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:437, tag android_compose_interactions_neon_node
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/Interactions.kt:631, tag android_compose_interactions_neon_indication
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:120, tag android_compose_userinteractions_material_ripple
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:187, tag android_compose_userinteractions_scale_indication_node_factory
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:199, tag android_compose_userinteractions_scale_indication_node
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:245, tag android_compose_userinteractions_localusefallbackrippleimplementation
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:254, tag android_compose_userinteractions_localusefallbackrippleimplementation_app_theme
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:264, tag android_compose_userinteractions_disabled_ripple_configuration
compose/snippets/src/main/java/com/example/compose/snippets/touchinput/userinteractions/UserInteractions.kt:284, tag android_compose_userinteractions_my_ripple_configuration

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

florina-muntenescu · 2024-01-24T18:49:21Z

compose/snippets/src/main/java/com/example/compose/snippets/designsystems/Material2Snippets.kt

@@ -14,7 +14,7 @@
 * limitations under the License.
 */

-@file:Suppress("unused")
+@file:Suppress("unused", "DEPRECATION_ERROR")


if something was deprecated here, i think we should check what it is and try to fix the DAC page.

it's ok to add this for now, but we should at least create a bug internally

I don't think we want to update the DAC page's snippet yet since 1.7.0 is still in alpha. We'll want to do that once 1.7.0 is stable (and the change would have to do be done on main)

florina-muntenescu · 2024-01-24T18:49:42Z

compose/snippets/src/main/java/com/example/compose/snippets/layouts/PagerSnippets.kt

@@ -426,7 +426,7 @@ private fun CustomSnapDistance() {
        HorizontalPager(
            state = pagerState,
            pageSize = PageSize.Fixed(200.dp),
-            beyondBoundsPageCount = 10,
+            outOfBoundsPageCount = 10,


is this change reflected in the guidance as well?

This change won't be affected in the guidance on DAC since it's on the latest branch (DAC mostly pulls snippets on the main branch unless explicitly specified to pull from another branch). However, we'll need to update this snippet once 1.7.0 is stable (we'll have to do that on the main branch)

florina-muntenescu · 2024-01-24T18:50:22Z

compose/snippets/src/main/java/com/example/compose/snippets/touchinput/focus/FocusSnippets.kt

@@ -14,6 +14,8 @@
 * limitations under the License.
 */

+@file:Suppress("DEPRECATION_ERROR")


same as above

Same comment here. I think there may be other snippets we'll have to update once 1.7.0 goes stable on the main branch (like if we deprecate other APIs).

Perhaps it'd be helpful for me to mention our branch policy in the README so that it is clear?

arriolac · 2024-01-24T19:55:37Z

Going to merge this in as it it currently blocking a DAC page release. If there are any comments / concerns I can address that separately.

Note that I also created #192 to keep main and latest in sync

* Add snippets for Indication and Ripple migration (#191) * Add ripple snippets. * Add new ripple APIs. * Add snippets for interactions. * Added more ripple snippets. * Update foundation and material to 1.7.0-alpha01 * Fix snippet tag. * Apply Spotless --------- Co-authored-by: arriolac <[email protected]> * Convert NeonIndication to data class. (#193) * Adding pip snippets to latest branch (#196) * Adding pip snippets to latest branch * Apply Spotless * Adding pip snippets to latest --------- Co-authored-by: MagicalMeghan <[email protected]> * Delete pictureInPicture. (#213) * Update activity compose level and align log tag with main branch (#215) * Migrate recomposeHighlighter to Modifier.Node (#197) (#238) * Migrate recomposeHighlighter to Modifier.Node * Apply Spotless * Simplify recompose highlighter * Apply Spotless --------- Co-authored-by: Tomáš Mlynarič <[email protected]> Co-authored-by: mlykotom <[email protected]> * Adding samples for ContextualFlowRow (#234) * Add snippets for ContextualFlowRow * Apply Spotless * Update flow snippets * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> * Update libs.versions.toml (#247) (#248) Update Compose BOM to 2024.04.00 Co-authored-by: MagicalMeghan <[email protected]> * Update Bitmap to image snippet to use new Graphics Layers (#254) * Update libs.versions.toml (#251) * Replace Graphics bitmap snippets with new Graphics Layer snippets. * Replace Graphics bitmap snippets with new Graphics Layer snippets. * Apply Spotless --------- Co-authored-by: Simona <[email protected]> Co-authored-by: riggaroo <[email protected]> * add shared element snippets * Apply Spotless * Split snippets into different files. * Apply Spotless * Shared element snippets (#256) * add shared element snippets * Apply Spotless * Split snippets into different files. * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> * Update libs.versions.toml (#251) (#252) Co-authored-by: Simona <[email protected]> * Snippet updates based on peer feedback. * Shared element snippets (#258) * add shared element snippets * Apply Spotless * Split snippets into different files. * Apply Spotless * Snippet updates based on peer feedback. * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> * Unique key snippet * Update SharedElementsWithNavigationSnippets.kt * Update AsyncImage snippet * Add placeholder size example * Add comment to snippet about unmatched bounds * 🤖 Sync main to latest (#259) * Update libs.versions.toml (#251) * Updated ListDetailPaneScaffold use to alpha12 (#255) This eliminates storing state outside and directly uses the navigator as the source of truth. This also gets rid of the Modifier for AnimatedPane as it's no longer a required argument. * Added NavigationSuiteScaffold snippets (#261) * Added NavigationSuiteScaffold snippets * Apply Spotless * 🤖 Update Dependencies (#262) * Added snippets for SupportingPaneScaffold (#260) * Added snippets for SupportingPaneScaffold * Apply Spotless * Update compose/snippets/src/main/java/com/example/compose/snippets/adaptivelayouts/SampleSupportingPaneScaffold.kt * Migrate to material3-adaptive WindowSizeClass method (#264) * Migrate to material3-adaptive WindowSizeClass method * Update comments to be single line * Apply Spotless --------- Co-authored-by: Simona <[email protected]> Co-authored-by: Ian G. Clifton <[email protected]> Co-authored-by: Alex Vanyo <[email protected]> Co-authored-by: compose-devrel-github-bot <[email protected]> * Update to new lazy list snippets. (#265) * Compose - beta01 (#270) * Update to new beta01 version * Apply Spotless * Update shared element text composable * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> * Added snippet for AnimatedVisibility usage with Shared elements (#272) * Added AnimatedVisibility shared element examples. * Apply Spotless * Switch to using LazyColumn instead of Grid as it has better animation support at present. * Apply Spotless * Fixed import. * Apply Spotless * Seperate samples into different files, simplify snippet. * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> * Add clickable text snippets (#297) * 🤖 Sync main to latest (#266) * Update CenterAlignedTopAppBar snippet to use centerAlignedTopAppBarColors * Time pickers comments (#295) * Adding advanced examples * Apply Spotless * Adding advanced examples * Rename AdvancedTimePickerExample * Rename AdvancedTimePickerExample --------- Co-authored-by: jakeroseman <[email protected]> * Adds preview and breakpoint --------- Co-authored-by: Jamal Eason <[email protected]> Co-authored-by: Jake Roseman <[email protected]> Co-authored-by: jakeroseman <[email protected]> Co-authored-by: Kat Kuan <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> * 🤖 Sync main to latest (#301) * Update CenterAlignedTopAppBar snippet to use centerAlignedTopAppBarColors * Time pickers comments (#295) * Adding advanced examples * Apply Spotless * Adding advanced examples * Rename AdvancedTimePickerExample * Rename AdvancedTimePickerExample --------- Co-authored-by: jakeroseman <[email protected]> * Adds preview and breakpoint * Updating DeviceConfigurationOverride snippet comment (#232) * Timepickers redux (#296) * Reworking the time picker examples to be more friendly to copy-pasting * Apply Spotless * Updating the time picker examples to be more copy-pastable * Change in-use tag name back to the current form. * Apply Spotless * Renaming region tags * Renaming region tags --------- Co-authored-by: jakeroseman <[email protected]> * Date pickers (#302) * Reworking the time picker examples to be more friendly to copy-pasting * Apply Spotless * Updating the time picker examples to be more copy-pastable * Change in-use tag name back to the current form. * Apply Spotless * Renaming region tags * Renaming region tags * Adding date picker snippets * Apply Spotless * fixing region tags * Adding additional range tags --------- Co-authored-by: jakeroseman <[email protected]> * Break long instruction in 2 lines to optimize for DAC * Prevent redrawing twice and running timer when compositions =0 (#304) --------- Co-authored-by: Jamal Eason <[email protected]> Co-authored-by: Jake Roseman <[email protected]> Co-authored-by: jakeroseman <[email protected]> Co-authored-by: Kat Kuan <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Alex Vanyo <[email protected]> Co-authored-by: Tomáš Mlynarič <[email protected]> * Snippet updates for type safe navigation APIs * Downgrade compileSdk to 34 * 🤖 Sync main to latest (#313) * Update CenterAlignedTopAppBar snippet to use centerAlignedTopAppBarColors * Time pickers comments (#295) * Adding advanced examples * Apply Spotless * Adding advanced examples * Rename AdvancedTimePickerExample * Rename AdvancedTimePickerExample --------- Co-authored-by: jakeroseman <[email protected]> * Adds preview and breakpoint * Updating DeviceConfigurationOverride snippet comment (#232) * Timepickers redux (#296) * Reworking the time picker examples to be more friendly to copy-pasting * Apply Spotless * Updating the time picker examples to be more copy-pastable * Change in-use tag name back to the current form. * Apply Spotless * Renaming region tags * Renaming region tags --------- Co-authored-by: jakeroseman <[email protected]> * Date pickers (#302) * Reworking the time picker examples to be more friendly to copy-pasting * Apply Spotless * Updating the time picker examples to be more copy-pastable * Change in-use tag name back to the current form. * Apply Spotless * Renaming region tags * Renaming region tags * Adding date picker snippets * Apply Spotless * fixing region tags * Adding additional range tags --------- Co-authored-by: jakeroseman <[email protected]> * Break long instruction in 2 lines to optimize for DAC * Prevent redrawing twice and running timer when compositions =0 (#304) * Allow Spotless to make commits on a user's behalf (#312) See diffplug/spotless#1242 --------- Co-authored-by: Jamal Eason <[email protected]> Co-authored-by: Jake Roseman <[email protected]> Co-authored-by: jakeroseman <[email protected]> Co-authored-by: Kat Kuan <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Alex Vanyo <[email protected]> Co-authored-by: Tomáš Mlynarič <[email protected]> Co-authored-by: Jolanda Verhoef <[email protected]> * Latest beta06 updates for Compose (#300) * Do latest 1.7.0-beta06 version updates * Apply Spotless * Code cleanup * Apply Spotless * Fix broken test * Fix tests --------- Co-authored-by: riggaroo <[email protected]> * Migrate CompositionLocal snippets to m3 (#321) (#323) Co-authored-by: Ben Trengrove <[email protected]> * Update snippets to use material3-adaptive rc01 (#324) * Migrate many snippets to use Material 3 instead of Material 2. (#320) * Do latest 1.7.0-beta06 version updates * Apply Spotless * Code cleanup * Apply Spotless * Fix broken test * Remove M2 usage from many snippets. * Apply Spotless * Remove M2 usage from many snippets. * Remove M2 usage from many snippets. * Revert incorrect commit --------- Co-authored-by: riggaroo <[email protected]> * Revert shape changes for now. * Fix text snippets in latest (#326) * Fix text snippets in latest * Apply Spotless * 🤖 Sync main to latest (#327) * Migrate CompositionLocal snippets to m3 (#321) * Migrate Custom design system page to M3 (#325) * Migrate Custom design system page to M3 * Apply Spotless --------- Co-authored-by: riggaroo <[email protected]> --------- Co-authored-by: Ben Trengrove <[email protected]> Co-authored-by: Rebecca Franks <[email protected]> Co-authored-by: riggaroo <[email protected]> * Updating DeviceConfigurationOverride snippet comment (#232) (cherry picked from commit a84c80d) * Bump actions/checkout from 3 to 4 (#222) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 2f34f3b) * Create dependabot.yml (#218) (cherry picked from commit db5ffc0) * Bump stefanzweifel/git-auto-commit-action from 4 to 5 (#221) Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 4 to 5. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v4...v5) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit d8ef2dd) * Bump actions/setup-java from 2 to 4 (#220) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit cea0c7d) * Set git config user for sync_main_latest workflow. (#230) * Set git config user for sync_main_latest workflow. * Update PR description. (cherry picked from commit ad9ffb0) * Fix merge * Fix merge * Apply Spotless * Fix merge --------- Co-authored-by: Chris Arriola <[email protected]> Co-authored-by: arriolac <[email protected]> Co-authored-by: MagicalMeghan <[email protected]> Co-authored-by: MagicalMeghan <[email protected]> Co-authored-by: compose-devrel-github-bot <[email protected]> Co-authored-by: compose-devrel-github-bot <[email protected]> Co-authored-by: Tomáš Mlynarič <[email protected]> Co-authored-by: mlykotom <[email protected]> Co-authored-by: riggaroo <[email protected]> Co-authored-by: Simona <[email protected]> Co-authored-by: Ian G. Clifton <[email protected]> Co-authored-by: Alex Vanyo <[email protected]> Co-authored-by: compose-devrel-github-bot <[email protected]> Co-authored-by: Ben Trengrove <[email protected]> Co-authored-by: Jamal Eason <[email protected]> Co-authored-by: Jake Roseman <[email protected]> Co-authored-by: jakeroseman <[email protected]> Co-authored-by: Kat Kuan <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Chiara Chiappini <[email protected]> Co-authored-by: Don Turner <[email protected]> Co-authored-by: Don Turner <[email protected]> Co-authored-by: Jolanda Verhoef <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

arriolac added 5 commits January 23, 2024 09:31

Add ripple snippets.

6080f42

Add new ripple APIs.

f962242

Add snippets for interactions.

974992d

Added more ripple snippets.

569af14

Update foundation and material to 1.7.0-alpha01

dedee21

arriolac and others added 3 commits January 24, 2024 10:39

Merge conflicts

b4ff086

Fix snippet tag.

694bd7d

Apply Spotless

ad3517b

florina-muntenescu reviewed Jan 24, 2024

View reviewed changes

arriolac merged commit d71778c into latest Jan 24, 2024
3 checks passed

arriolac deleted the chris/ui/ripple branch January 24, 2024 19:56

arriolac mentioned this pull request Jan 24, 2024

Convert NeonIndication to data class #193

Merged

arriolac mentioned this pull request Feb 9, 2024

Remove pictureInPicture dir #213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add snippets for Indication and Ripple migration #191

Add snippets for Indication and Ripple migration #191

arriolac commented Jan 24, 2024

snippet-bot bot commented Jan 24, 2024 •

edited

Loading

florina-muntenescu Jan 24, 2024

arriolac Jan 24, 2024

florina-muntenescu Jan 24, 2024

arriolac Jan 24, 2024 •

edited

Loading

florina-muntenescu Jan 24, 2024

arriolac Jan 24, 2024 •

edited

Loading

arriolac commented Jan 24, 2024

Add snippets for Indication and Ripple migration #191

Add snippets for Indication and Ripple migration #191

Conversation

arriolac commented Jan 24, 2024

snippet-bot bot commented Jan 24, 2024 • edited Loading

florina-muntenescu Jan 24, 2024

Choose a reason for hiding this comment

arriolac Jan 24, 2024

Choose a reason for hiding this comment

florina-muntenescu Jan 24, 2024

Choose a reason for hiding this comment

arriolac Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

florina-muntenescu Jan 24, 2024

Choose a reason for hiding this comment

arriolac Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

arriolac commented Jan 24, 2024

snippet-bot bot commented Jan 24, 2024 •

edited

Loading

arriolac Jan 24, 2024 •

edited

Loading

arriolac Jan 24, 2024 •

edited

Loading