Use lazy vertical staggered grid in feed to maximize space utilization #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also consider setting a max line param for the cards. Long cards that stretch the full height of the screen are a bit awkward visually, and cause jumps in the scrollbar due to the high variability in the number of cards that show up on the screen. |
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
Change-Id: I7ee8bc84beb38d00983aa7b0da3f3073e1249992
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
tunjid
force-pushed
the
tj/staggered-grid-feed
branch
from
85aeabb
to
7745177
Compare
mmoczkowski
reviewed
Sep 25, 2023
...n/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
Outdated
Show resolved
Hide resolved
mmoczkowski
reviewed
Sep 25, 2023
...n/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
Show resolved
Hide resolved
alexvanyo
reviewed
Sep 25, 2023
app/src/testDemo/screenshots/expandedWidth_expandedHeight_showsNavigationRail.png
Outdated
Show resolved
Hide resolved
Change-Id: I50b49d3e216535e384b64849f915b37f6e2acbbc
Change-Id: Ia931fc5662af50a6045a51783d72cb5b68e2486a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the content grid with a staggered grid bringing us more in line with the M3 feed guidance.
Screenshots to be updated in a bit.