Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @After to guarantee DB was closed. #1240

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Add @After to guarantee DB was closed. #1240

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45f327f
Add @After to guarantee DB was closed.
Jaehwa-Noh Mar 3, 2024
2438e17
Merge branch 'android:main' into Close-DB
Jaehwa-Noh Mar 4, 2024
ed36478
Fix spotless
Jaehwa-Noh Mar 4, 2024
835c7b3
Merge branch 'android:main' into Close-DB
Jaehwa-Noh Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...Test/kotlin/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDaoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import com.google.samples.apps.nowinandroid.core.database.model.asExternalModel
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.test.runTest
import kotlinx.datetime.Instant
import org.junit.After
import org.junit.Before
import org.junit.Test
import kotlin.test.assertEquals
Expand All @@ -48,6 +49,11 @@ class NewsResourceDaoTest {
topicDao = db.topicDao()
}

@After
fun closeDb() {
db.close()
}
Jaehwa-Noh marked this conversation as resolved.
Show resolved Hide resolved

@Test
fun newsResourceDao_fetches_items_by_descending_publish_date() = runTest {
val newsResourceEntities = listOf(
Expand Down
Loading