Upgrade Spotless and Ktlint and remove code convention violations #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturner
reviewed
Dec 19, 2023
app/src/main/kotlin/com/google/samples/apps/nowinandroid/navigation/NiaNavHost.kt
Outdated
Show resolved
Hide resolved
benchmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/startup/StartupBenchmark.kt
Show resolved
Hide resolved
...otlin/com/google/samples/apps/nowinandroid/core/network/fake/FakeNiaNetworkDataSourceTest.kt
Outdated
Show resolved
Hide resolved
core/common/src/test/kotlin/com/google/samples/apps/nowinandroid/core/result/ResultKtTest.kt
Outdated
Show resolved
Hide resolved
dturner
approved these changes
Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Upgrade Spotless from 6.22.0 to 6.23.3
Upgrade ktlint from 0.48.1 to 1.0.1
Fixed all spotless errors in the project
Remove violations: discouraged-comment-location
Remove violations: property-naming
Do tests pass?
DemoDebugvariant:./gradlew testDemoDebug./gradlew --init-script gradle/init.gradle.kts spotlessApply