Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndk-which should work with different ABIs #56

Closed
tux-mind opened this issue Mar 30, 2016 · 3 comments
Closed

ndk-which should work with different ABIs #56

tux-mind opened this issue Mar 30, 2016 · 3 comments
Assignees
@enh
Labels
help wanted
Milestone
r18

Comments

@tux-mind
Copy link

ndk-which uses only the armeabi ABI.

in my specific case ndk-which strip gives $NDK_ROOT/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip when what I want is $NDK_ROOT/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-strip.

I think that ndk-which shall accept an optional argument or change it's behaviour from the current environment.

Best regards.
@DanAlbert DanAlbert added this to the r12 milestone Mar 30, 2016
@DanAlbert DanAlbert self-assigned this Mar 30, 2016
@DanAlbert DanAlbert modified the milestones: r12, r13 May 24, 2016
@DanAlbert DanAlbert modified the milestones: r14, r13 Aug 9, 2016
@DanAlbert DanAlbert removed this from the r14 milestone Jan 4, 2017
@enh
Copy link
Contributor

enh commented Jun 3, 2017

maybe add "--abi x86" or something. should probably move to python at the same time to benefit Windows users (rather than do bash argument parsing).

@DanAlbert DanAlbert added this to the unplanned milestone Mar 16, 2018
@rcombs rcombs mentioned this issue Jul 27, 2018
Closed
@enh enh assigned enh and unassigned DanAlbert Jul 27, 2018
@enh enh modified the milestones: unplanned, r18 Aug 8, 2018
@enh
Copy link
Contributor

enh commented Aug 8, 2018

https://android-review.googlesource.com/c/platform/ndk/+/722891 added --abi and switched the default.

https://android-review.googlesource.com/c/platform/ndk/+/723009 cherrypicked this for r18 beta 2.

@DanAlbert
Copy link
Member

Merged into r18.

@dan-ryan dan-ryan mentioned this issue Sep 11, 2018
Closed
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
@enh-google
Update git submodules
7c1d5d6 
* Update ndk from branch 'master'
  to e1f0ad12fc317c0ca3183529cc9625d3f084d981
  - Merge "ndk-which: support all ABIs."
  - ndk-which: support all ABIs.
    
    Also switch the default to armeabi-v7a rather than armeabi which was
    removed in r17.
    
    We should probably just remove this tool, but as long as it's there,
    we should make it work.
    
    Bug: android/ndk#755
    Bug: android/ndk#56
    Test: `ndk-which --abi x86 objdump` and `ndk-which objdump`
    Change-Id: I034ee26d1a695bf771a0f38e0097650b61a78ca6
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
@enh-google
Update git submodules
b027357 
* Update ndk from branch 'master'
  to e1f0ad12fc317c0ca3183529cc9625d3f084d981
  - Merge "ndk-which: support all ABIs."
  - ndk-which: support all ABIs.
    
    Also switch the default to armeabi-v7a rather than armeabi which was
    removed in r17.
    
    We should probably just remove this tool, but as long as it's there,
    we should make it work.
    
    Bug: android/ndk#755
    Bug: android/ndk#56
    Test: `ndk-which --abi x86 objdump` and `ndk-which objdump`
    Change-Id: I034ee26d1a695bf771a0f38e0097650b61a78ca6
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
@enh-google
Update git submodules
d2cf614 
* Update ndk from branch 'master'
  to e1f0ad12fc317c0ca3183529cc9625d3f084d981
  - Merge "ndk-which: support all ABIs."
  - ndk-which: support all ABIs.
    
    Also switch the default to armeabi-v7a rather than armeabi which was
    removed in r17.
    
    We should probably just remove this tool, but as long as it's there,
    we should make it work.
    
    Bug: android/ndk#755
    Bug: android/ndk#56
    Test: `ndk-which --abi x86 objdump` and `ndk-which objdump`
    Change-Id: I034ee26d1a695bf771a0f38e0097650b61a78ca6
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
324c557 
* Update ndk from branch 'ndk-release-r18'
  to 477efcead24f1107e0200bbf75176913b38e9d01
  - Merge "ndk-which: support all ABIs." into ndk-release-r18
  - ndk-which: support all ABIs.
    
    Also switch the default to armeabi-v7a rather than armeabi which was
    removed in r17.
    
    We should probably just remove this tool, but as long as it's there,
    we should make it work.
    
    Bug: android/ndk#755
    Bug: android/ndk#56
    Test: `ndk-which --abi x86 objdump` and `ndk-which objdump`
    Change-Id: I034ee26d1a695bf771a0f38e0097650b61a78ca6
    (cherry picked from commit e97023726375a8bd49a0e4da376b1da12624c3b3)
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
5265b72 
* Update ndk from branch 'ndk-release-r18'
  to ed20dd9dd6b153bd13d412ad4a6843bd74fcd0cb
  - Merge "ndk-which: require exact ABI strings" into ndk-release-r18
  - ndk-which: require exact ABI strings
    
    e.g. Allow x86, but not x86-foo or foo-x86.
    
    Bug: android/ndk#755
    Bug: android/ndk#56
    Test: `ndk-which --abi x86-foo objdump`
    Test: `ndk-which --abi foo-x86 objdump`
    Change-Id: If9bc43847265be90b432a3cb7b112040580726c8
    (cherry picked from commit d626c3f2673f7e2681eba5090524f49d44cfb429)
@AlexanderSerov AlexanderSerov mentioned this issue Jun 7, 2021
Closed
@sruPL sruPL mentioned this issue Apr 30, 2024
Closed
@notyalcs notyalcs mentioned this issue May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enh enh

Labels
help wanted
Projects
None yet
Milestone
r18
Development

No branches or pull requests
3 participants
@DanAlbert @tux-mind @enh