Remove fragile gradle parsing. #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My PGO sample broke this because it uses double quotes. Rather than fix the "parser", just explicitly list the versions we use here. Auto- detection is nice if we *want* to have a lot of versions supported, but we don't.
DanAlbert
force-pushed
the
stop-parsing-gradle
branch
from
ffe5f66
to
d751697
Compare
|
#1010 will make this unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PGO sample broke this because it uses double quotes. Rather than fix the "parser", just explicitly list the versions we use here. Auto-detection is nice if we want to have a lot of versions supported, but we don't.