Remove unused dependencies from native-activity. #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These dependencies were not actually used but were in contradiction with the `android:hasCode=false` in the manifest. Remove the pointless dependencies, but leave some comments explaining to anyone that copies from here that they need to update `app:hasCode` if they add any DEX to their app. Fixes android#929.
DanAlbert
force-pushed
the
fix-native-activity
branch
from
d2b36fe
to
068c60b
Compare
This was referenced Apr 16, 2024
enh-google
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These dependencies were not actually used but were in contradiction with the
android:hasCode=falsein the manifest. Remove the pointless dependencies, but leave some comments explaining to anyone that copies from here that they need to updateapp:hasCodeif they add any DEX to their app.Fixes #929.