Use Fruitties ViewModel on iOS #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cartland
commented
Sep 10, 2024
•
cartland
commented
- Create IOSViewModelOwner in native source set
- Instantiate IOSViewModelOwner in iOSApp.swift
- Add helper function MainViewModel.newCreationExtras()
- Instantiate MainViewModel in IOSViewModelOwner
- collect() KMP StateFlow to State with SKIE preview API
- https://skie.touchlab.co/features/flows-in-swiftui
- Delete UIModel and use ViewModel directly
- Cart calculates total items, not number of distinct items
- Simplify Fruitties UI to match Android & iOS
dlam
reviewed
Sep 10, 2024
dlam
reviewed
Sep 10, 2024
Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/ListScreen.kt
Outdated
Show resolved
Hide resolved
dlam
reviewed
Sep 11, 2024
Fruitties/shared/src/nativeMain/kotlin/com/example/fruitties/di/viewmodel/IOSViewModelOwner.kt
Outdated
Show resolved
Hide resolved
* addToCart does not need async keyword * await (home, cart) created an Xcode warning: Expression of type '((), ())' is unused * The async functions never return, so fixed by assigning result to _
* Minimum iOS deployment: 17.0 * Migrating from the Observable Object protocol to the Observable macro * https://developer.apple.com/documentation/swiftui/migrating-from-the-observable-object-protocol-to-the-observable-macro
paween
reviewed
Sep 22, 2024
* "Cart has $total items" * CartUiState -> CartUIState
* https://skie.touchlab.co/features/flows-in-swiftui * Delete UIModel * Delete StateHelper.swift
cartland
force-pushed
the
viewmodel-ios
branch
from
272e3df to
06e67d1
Compare
cartland
force-pushed
the
viewmodel-ios
branch
from
06e67d1 to
f23f39a
Compare
cartland
force-pushed
the
viewmodel-ios
branch
from
74d2d24 to
a1ea1f7
Compare
dlam
approved these changes
Sep 25, 2024
alexvanyo
reviewed
Sep 26, 2024
Fruitties/androidApp/src/main/java/com/example/fruitties/android/MyApplicationTheme.kt
Outdated
Show resolved
Hide resolved
* Edge-to-edge: Use contentWindowInsets to allow drawing to Bottom edge * TopBar: Use CenterAlignedTopAppBar to simplify centering
alexvanyo
approved these changes
Sep 26, 2024
|
Smail thing but be good to update following in REAMDE to include "Fruitties is a sample app using the Kotlin Multiplatform Room, DataStore and Ktor libraries to fetch, store and display data." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.