Update protobuf to 3.6.1.2 #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use one single protobuf external repo
|
FYI @jin |
|
@brettchabot not sure why import/copybara is failing, are there any logs for that? |
|
It looks like copybara isn't configured to export (and import?) changes made to the tools/ directory. I made an internal CL with the same change to test this out, and the tools/ directory changes were not exported out. #148 |
copybara-androidxtest
pushed a commit
that referenced
this pull request
Dec 6, 2018
… Bazel breaking changes. Bazel HEAD removed the --incompatible_package_name_is_a_function flag, causing upstream protobuf older than 3.6.1 to completely fail to build. This CL updates @android_test_support's protobuf version to 3.6.1.2, which builds with Bazel HEAD. See android/testing-samples#226 Also see #147 PiperOrigin-RevId: 224340571
copybara-androidxtest
pushed a commit
that referenced
this pull request
Dec 6, 2018
… Bazel breaking changes. Bazel HEAD removed the --incompatible_package_name_is_a_function flag, causing upstream protobuf older than 3.6.1 to completely fail to build. This CL updates @android_test_support's protobuf version to 3.6.1.2, which builds with Bazel HEAD. See android/testing-samples#226 Also see #147 PiperOrigin-RevId: 224340571
copybara-androidxtest
pushed a commit
that referenced
this pull request
Dec 6, 2018
… Bazel breaking changes. Bazel HEAD removed the --incompatible_package_name_is_a_function flag, causing upstream protobuf older than 3.6.1 to completely fail to build. This CL updates @android_test_support's protobuf version to 3.6.1.2, which builds with Bazel HEAD. See android/testing-samples#226 Also see #147 PiperOrigin-RevId: 224356109
|
I had to split this PR up internally, because it touches two packages that each have their own copybara export process. The changes are now in master; thanks @meteorcloudy for looking into this!! |
rauljurado620
added a commit
to rauljurado620/test-android-project
that referenced
this pull request
Mar 24, 2022
… Bazel breaking changes. Bazel HEAD removed the --incompatible_package_name_is_a_function flag, causing upstream protobuf older than 3.6.1 to completely fail to build. This CL updates @android_test_support's protobuf version to 3.6.1.2, which builds with Bazel HEAD. See android/testing-samples#226 Also see android/android-test#147 PiperOrigin-RevId: 224356109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one single protobuf external repo.