Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

sahishnu111
Copy link

@sahishnu111 sahishnu111 commented Oct 10, 2024

Description: Choose Password Generation Type (Classic vs XKPasswd) at Generation Time

This pull request implements the feature to choose between classic and XKPasswd password generation methods directly when generating a password. This addresses the current limitation of having to set the generation type in settings.

Benefits:

  • Improved user experience: Users can easily switch between password generation methods without navigating to settings.
  • Increased flexibility: Allows users to choose the most appropriate generation method based on their specific needs.

Changes:

  • The PasswordScreen component now includes a button with an icon to trigger a password generation dialog.
  • The PasswordGenerationDialog component displays options for:
    • Password type (XKPasswd or Alphanumeric) with a dropdown menu.
    • Password length with a text field.
    • Separator for XKPasswd generation (optional, with a text field).
  • Clicking "Generate" generates a password based on the chosen type and parameters.
  • Clicking "OK" in the dialog updates the password field in the main screen with the generated password.

Code Changes:

  • Modifications are made to the PasswordScreen and PasswordGenerationDialog composables.
  • New DropdownWithOptions composable is added to handle the dropdown menu for password types.
  • Existing generateXKPasswd and generateAlphanumericPassword functions are used for password generation.

Testing:

  • Unit tests have been added to cover the new functionalities.

Additional Notes:

I hope this pull request contributes positively to the project!
Screenshot 2024-10-10 183038

…time, not in settings

Currently, the password generation type (classic vs XKPasswd) is set in the application settings. This can be inconvenient as users may want to switch between different generation methods without having to modify their settings.

I propose adding an option to choose the password generation type directly at the time of password generation. This would provide more flexibility and convenience for users.
@msfjarvis
Copy link
Member

I am not interested in AI slop

@msfjarvis msfjarvis closed this Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants