This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Choose password generation type (classic vs XKPasswd) at generation time, not in settings #3259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Choose Password Generation Type (Classic vs XKPasswd) at Generation Time
This pull request implements the feature to choose between classic and XKPasswd password generation methods directly when generating a password. This addresses the current limitation of having to set the generation type in settings.
Benefits:
Changes:
PasswordScreen
component now includes a button with an icon to trigger a password generation dialog.PasswordGenerationDialog
component displays options for:Code Changes:
PasswordScreen
andPasswordGenerationDialog
composables.DropdownWithOptions
composable is added to handle the dropdown menu for password types.generateXKPasswd
andgenerateAlphanumericPassword
functions are used for password generation.Testing:
Additional Notes:
I hope this pull request contributes positively to the project!