Exclude embedded attribute from code coverage #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The embedded EnumExtensionsAttribute should be excluded from code coverage. This can be done using the [ExcludeFromCodeCoverage](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.excludefromcodecoverageattribute) attribute. The attribute is available in the following .NET products: - .NET Standard: >= 2.0 - .NET Framework: >= 4.0 - .NET: >= Core 2.0
|
Thanks for adding this! I think you'll need to update the snapshots to reflect the change to the output so that the tests pass. Is that something you're happy to do? If not I'll take a look soon. Thanks! 🙂 |
[`ExcludeFromCodeCoverageAttribute.Justification`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.excludefromcodecoverageattribute.justification?view=net-7.0#system-diagnostics-codeanalysis-excludefromcodecoverageattribute-justification) is only available starting with .NET 5.
The .NET 6 and 7 tests ran without issues. I didn't test other .NET versions because I only have the SDKs for .NET 6 and 7 installed. I checked the snapshots, and it doesn't look like they include the embedded attribute. |
|
Thanks @erri120, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded EnumExtensionsAttribute should be excluded from code coverage. This can be done using the ExcludeFromCodeCoverage attribute. The attribute is available in the following .NET products and shouldn't require any version guarding: