Switch to ForAttributeWithMetadataName
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
force-pushed
the
ForAttributeWithMetadataName
branch
from
9b3270b to
ad4ec9e
Compare
andrewlock
force-pushed
the
ForAttributeWithMetadataName
branch
3 times, most recently
from
d0404f9 to
26895c4
Compare
andrewlock
force-pushed
the
ForAttributeWithMetadataName
branch
from
26895c4 to
456cc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 7 introduced an optimised api for source generation,
ForAttributeWithMetadataName, which takes care of finding all types decorated with a given attribute, skipping any symbols where it's not possible, greatly reducing the perf impact.This PR also introduces
EquatableArrayas a wrapper for a native array to ensure we correctly compare identical types, and avoid unnccessary output