Endpoint security middleware #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added a commit
that referenced
this pull request
Sep 6, 2024
* Update FluentAssertions * Split out EndpointSecurityHeadersMiddleware from SecurityHeadersMiddleware
andrewlock
added a commit
that referenced
this pull request
Sep 15, 2024
* Update FluentAssertions * Split out EndpointSecurityHeadersMiddleware from SecurityHeadersMiddleware
This was referenced Sep 15, 2024
andrewlock
added a commit
that referenced
this pull request
Sep 25, 2024
* Update FluentAssertions * Split out EndpointSecurityHeadersMiddleware from SecurityHeadersMiddleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some changes to the design of the endpoint-specific endpoints work in #172 . tl;dr; call
UseSecurityHeaders()as before, at the start of the middleware pipeline, and then callUseEndpointSecurityHeaders()afterUseRouting().I think this is preferable as it's much easier to explain and reason about, and we don't have to worry about "overrides" so much etc