Feature/add l tile layer wms #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgryan
reviewed
Oct 30, 2024
src/l-tile-layer-wms.js
Outdated
| attribution: optional(htmlAttribute("attribution")), | ||
|
|
||
| // Optional options | ||
| options: optional(htmlAttribute("options")), |
There was a problem hiding this comment.
I think this needs to be JSON parsed and merged with the other wmsOptions object. At least, that's my understanding from the Leaflet WMS docs
There was a problem hiding this comment.
Ah great point. Addressed in 5756053
…g, and parse accordingly. Also written tests and formatted.
andrewgryan
reviewed
Oct 30, 2024
src/l-tile-layer-wms.js
Outdated
| "Error whilst parsing JSON for options attribute in l-tile-layer-wms", | ||
| e, | ||
| ); | ||
| return null; |
There was a problem hiding this comment.
How does this behave with ... destructuring?
andrewgryan
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that addresses 3/4 requirements from Issue 45: Add WMS Layer Support.