[kodi] fix possible resource leak (openhab#8030)

Signed-off-by: Jan N. Klug <[email protected]>
andrewfg · Aug 31, 2020 · 0497815 · 0497815
1 parent 0589cca
commit 0497815
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/bundles/org.openhab.binding.kodi/pom.xml b/bundles/org.openhab.binding.kodi/pom.xml
@@ -1,4 +1,6 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
   <modelVersion>4.0.0</modelVersion>
 

diff --git a/...nding.kodi/src/main/java/org/openhab/binding/kodi/internal/protocol/KodiClientSocket.java b/...nding.kodi/src/main/java/org/openhab/binding/kodi/internal/protocol/KodiClientSocket.java
@@ -15,6 +15,7 @@
 import java.io.IOException;
 import java.net.URI;
 import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Future;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
 
@@ -58,6 +59,7 @@ public class KodiClientSocket {
     private final URI uri;
     private final WebSocketClient client;
     private Session session;
+    private Future<?> sessionFuture;
 
     private final KodiClientSocketEventListener eventHandler;
 
@@ -81,7 +83,7 @@ public synchronized void open() throws IOException {
         KodiWebSocketListener socket = new KodiWebSocketListener();
         ClientUpgradeRequest request = new ClientUpgradeRequest();
 
-        client.connect(socket, uri, request);
+        sessionFuture = client.connect(socket, uri, request);
     }
 
     /***
@@ -93,6 +95,10 @@ public void close() {
             session.close();
             session = null;
         }
+
+        if (sessionFuture != null && !sessionFuture.isDone()) {
+            sessionFuture.cancel(true);
+        }
     }
 
     public boolean isConnected() {