Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge devices in menu by serial, but allow multiple connection method… #740

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

andrewdavidmackenzie
Copy link
Owner

Fixes #738

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 0.97087% with 102 lines in your changes missing coverage. Please review.

Project coverage is 29%. Comparing base (3dc7fe9) to head (5c1ddca).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/discovery.rs 0% 39 Missing ⚠️
src/views/hardware_menu.rs 0% 26 Missing ⚠️
src/piggui.rs 0% 14 Missing ⚠️
src/piglet.rs 0% 14 Missing ⚠️
src/views/info_dialog.rs 15% 6 Missing ⚠️
src/usb.rs 0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master   #740   +/-   ##
=====================================
+ Coverage      29%    29%   +1%     
=====================================
  Files          45     45           
  Lines        5835   5821   -14     
=====================================
  Hits         1634   1634           
+ Misses       4201   4187   -14     
Flag Coverage Δ
unittests 29% <1%> (+1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 3ca817e into master Dec 16, 2024
17 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg_738 branch December 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine list of discovered devices by key again
1 participant