Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialog spacing #488

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Fix dialog spacing #488

merged 7 commits into from
Oct 4, 2024

Conversation

sundaram123krishnan
Copy link
Collaborator

Tried reducing the spacing between the 2 buttons of the warning modal

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29%. Comparing base (a676ac1) to head (23da56b).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/piggui.rs 0% 1 Missing ⚠️
src/views/modal_handler.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master   #488   +/-   ##
=====================================
+ Coverage      29%    29%   +1%     
=====================================
  Files          43     43           
  Lines        5142   5138    -4     
=====================================
  Hits         1488   1488           
+ Misses       3654   3650    -4     
Flag Coverage Δ
unittests 29% <0%> (+1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie
Copy link
Owner

This fixes the problem.
I'd prefer a more flexible way to layout dialogs (e.g. left justify left botton, right justify right button, minumum space between them, and the overall width adjusts so they fit without text wrapping) but I guess we'll leave that as a future exercise.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 56b056a into master Oct 4, 2024
15 of 16 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg-483 branch October 4, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants