Gatsby V3 #146
Gatsby V3 #146
Conversation
There was a problem hiding this comment.
Thanks for the help! Running yarn test -u should update all the baselines. There are some instructions in CONTRIBUTING.md.
|
All of the GraphQL resolvers are failing. Does the |
|
My bad, react is now a peerDependency of gatsby, so it does need to be installed. The issue is that gatsby's local server (used to test GraphQL queries) isn't spinning up at all. I'm taking a look and will push an update. |
|
@tnorlund, can you check the box on the PR that allows maintainers to make edits? That will let me push a commit. |
It's already checked. Do you want me to uncheck it? |
|
Oh, I think it's because it's on the master branch of your fork. I think the easiest thing to do would be to give me push access to your fork. Otherwise I'll have to PR into your PR. |
|
I added you as a collaborator. Does that work? |
|
That worked, thanks! |
There was a problem hiding this comment.
Ok, tests are working, which is a good sign. I think before merging, I would like to get the example site updated to v3 as well just so we can see that it works fully integrated in a real gatsby environment. Would you mind looking into that? I really don’t care whether it’s upgraded in place or recreated with gatsby new and the content and config dropped back in. Whatever you think is easier, if you’re up for it.
|
Are you referring to the site in |
|
Yep, that’s the one. |
|
Alright. I'm going to make the changes required for Gatsby V3. |
|
Tests pass locally, fail in GH Action. Any idea why? |
|
If I can help with anything else, please let me know! |
|
I guess that's it. I'd like to add this to my blog once it's been merged. It's a neat plugin. |
|
Thanks so much! |
I'd really like to get this working with Gatsby V3. I'm having issues with the Jest suite. I'm not sure how to generate another snapshot in
__snapshots__. Could you help me out?