Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcpdump for linux x86_64 #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jm33-m0
Copy link

@jm33-m0 jm33-m0 commented Aug 2, 2020

stripped, upx compressed

stripped, upx compressed
@jm33-m0
Copy link
Author

jm33-m0 commented Aug 2, 2020

Compiled with musl libc under Alpine linux

@mathieu-aubin
Copy link
Contributor

I wouldnt be the person who would trust anything UPX compressed that plays in such a sensitive area as networking... Why the need to compress? Where is the build script so i can replicate? I can only see ARM architecture as far as build script and frankly, to me, providing a compressed binary and trying to submit only a finished executable, without any trace evidences of something suposedly replicable or at least something that goes with the lines of this repository/project, aka build files rather than a binary collection, sounds/looks very very fishy.

Anyone agrees? Sorry i do not know you, nor have i looked at your profile or am i basing myself on anything more than the very nature of this pull request so nothing personnal.

Pull a build script, that works with the current build engine so its at least relevant to the project

Copy link
Contributor

@mathieu-aubin mathieu-aubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to provide a build script that is relevant to the build system that this project is, wouldn't it?

@jm33-m0
Copy link
Author

jm33-m0 commented Aug 3, 2020

Ok, I will put a docker file and a build script later, thanks for the advice

@mathieu-aubin
Copy link
Contributor

look at the current repository's build system work and best is to keep the same structure/logic so it's reproducible and well, at least tis way the file can't be a possible 'dud' after people can build their own... also, having source code is always great.

I myself am a fan of static binaries but mainly for things that are not standard from distro to the next. This way and at least for me, i keep a 'toolbox' of tools that i need on a very close to daily basis and which i don't want to FU******* around recompiling to install or just to get the latest version.

Then i have a bash function that checks for server's files (toolbox is online and available password-protected). A quick hash check makes sure that i always can carry the best, latest toolbox as i have compiled it.

Thank you for your kind response, many wouldn't have liked such a straightforward attitude from some unknown jerk (me)!

Thanks

@jm33-m0
Copy link
Author

jm33-m0 commented Aug 9, 2020

Fix #6

@jm33-m0
Copy link
Author

jm33-m0 commented Aug 23, 2020

@mathieu-aubin I've updated with build script and a stripped (without compression) tcpdump binary.

The build script runs in official Alpine docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants