Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribs #389

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Attribs #389

merged 2 commits into from
Jan 6, 2024

Conversation

andrew-codechimp
Copy link
Owner

No description provided.

@andrew-codechimp andrew-codechimp linked an issue Jan 6, 2024 that may be closed by this pull request
3 tasks
@andrew-codechimp andrew-codechimp merged commit ebeaa44 into main Jan 6, 2024
1 of 3 checks passed
@andrew-codechimp andrew-codechimp deleted the attribs branch January 6, 2024 14:06
@andrew-codechimp andrew-codechimp restored the attribs branch January 6, 2024 14:08
@nechry
Copy link
Contributor

nechry commented Jan 6, 2024

just curious, would it be possible to add theres attributes directly to the battery entity? basically like I do with the customize. if yes by adding the last replacement date I could directly use my battery report

@andrew-codechimp
Copy link
Owner Author

I'll have a look at how customize adds attributes and see if it's possible from another integration. It would make life easier if I can get them onto the battery entity as well.

@andrew-codechimp
Copy link
Owner Author

Customize is adding attributes when the sensor updates, looking at how it does it it clears all existing attributes and re-creates them so if I forced an attribute on the battery sensor it would be removed when the sensor refreshes so doesn't look like I'll be able to do this. Shame as that would open up some interesting possibilities.
I'll continue with the attributes on the battery_type sensor which will I'll put in a release within the next week.

@nechry
Copy link
Contributor

nechry commented Jan 7, 2024

ok thank you for this try, it's a shame that HA doesn't try to merge the attributes instead of replacing them. but I will already be happy to get attributes about battery type as in the original request anyway. thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add battery_quantity attribute to battery_type entity
2 participants