Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System call rework #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheThirdOne
Copy link

This addresses #37. I made the changes to Syscall.java to implement it and then updated all of the tests and the fibonacci example to work with the new system.

I have run gradlew test and all of the tests pass with the modifications to the tests. That isn't quite conclusive that everything is working as intended though. I have not checked that each system call works as intended and there don't seem to be automated tests for that.

On my local version I also modified the error message in RISCVTests.java. The original was not helpful in finding which test I had missed.

-      assertEquals("Jupiter(0)", e.getMessage(), "failed: " + file.toString());
+      assertEquals("Jupiter(0)", e.getMessage(), "failed: " + file[0].getName());

I can also modify the documentation if you would like, but that is in a different repo so it will need to be a different PR.

One minor problem with this change is that user inputs can now get
clobbered by return values. However, this is the standard ecall convention.

This only changes the java code involved and does not modify any
assembly tests (so they now fail).
@TheThirdOne
Copy link
Author

@andrescv, is there a reason this had yet to be merged?

@MaxCrazy1101
Copy link

How to build the project? I'm new for java and riscv<3

@TheThirdOne
Copy link
Author

@Diaosi1111, this project uses gradle to build and has a gradle wrapper set up. Just running gradlew build or gradlew.bat build will build the project.

More information about gradle can be found at https://spring.io/guides/gs/gradle/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants