Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #37. I made the changes to
Syscall.java
to implement it and then updated all of the tests and the fibonacci example to work with the new system.I have run
gradlew test
and all of the tests pass with the modifications to the tests. That isn't quite conclusive that everything is working as intended though. I have not checked that each system call works as intended and there don't seem to be automated tests for that.On my local version I also modified the error message in RISCVTests.java. The original was not helpful in finding which test I had missed.
I can also modify the documentation if you would like, but that is in a different repo so it will need to be a different PR.