mTLS authentication w/ tests #4
Conversation
| ) | ||
|
|
||
| func init() { | ||
| flag.IntVar(&grpcPort, "grpc-port", 50051, "Port to expose the gRPC server on") |
There was a problem hiding this comment.
nit: Define default port number constant since it is used by both server and client.
| tc := validTestCase() | ||
| tc.clientCredsFiles.Cert = "self-signed.crt" | ||
| tc.clientCredsFiles.Key = "self-signed.key" | ||
| tc.expectedErr = errors.New("context deadline exceeded") |
There was a problem hiding this comment.
Is it possible to improve the error handling for this case? Receiving a 'context deadline exceeded' here might not be too helpful in figuring out what went wrong.
There was a problem hiding this comment.
The only option I see is to somehow inspect the logs emitted by the grpc framework. In the returned error object itself, the more precise message seems to be just a "connection error" or "connection closed".
There was a problem hiding this comment.
does grpc.WithBlock() (or some other dial option) help catch the TLS error early?
There was a problem hiding this comment.
Not really. I already use grpc.WithReturnConnectionError() which implies grpc.WithBlock() and is even more helpful in this regard.
| tc := validTestCase() | ||
| tc.clientCredsFiles.Cert = "self-signed.crt" | ||
| tc.clientCredsFiles.Key = "self-signed.key" | ||
| tc.expectedErr = errors.New("context deadline exceeded") |
There was a problem hiding this comment.
does grpc.WithBlock() (or some other dial option) help catch the TLS error early?
No description provided.