Merge cockroachdb#63852 cockroachdb#63854

63852: server: skip TestTelemetrySQLStatsIndependence r=tbg a=knz

This test flakes if the reg server is temporarily unavailable.

Informs  cockroachdb#63844, cockroachdb#63851,  cockroachdb#63848

63854: sqlsmith: don't use crdb_internal.create_join_token r=yuzefovich a=yuzefovich

This is an internal builtin, and we probably don't get much when using
it in the sqlsmith. Currently this builtin occasionally leads to an
internal error.

Addresses: cockroachdb#63819.

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>

pkg/internal/sqlsmith/schema.go

@@ -481,7 +481,8 @@ var functions = func() map[tree.FunctionClass]map[oid.Oid][]function {
 			continue
 		}
 		if strings.Contains(def.Name, "crdb_internal.force_") ||
-			strings.Contains(def.Name, "crdb_internal.unsafe_") {
+			strings.Contains(def.Name, "crdb_internal.unsafe_") ||
+			strings.Contains(def.Name, "crdb_internal.create_join_token") {
 			continue
 		}
 		if _, ok := m[def.Class]; !ok {

pkg/server/stats_test.go

@@ -27,6 +27,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/tests"
 	"github.com/cockroachdb/cockroach/pkg/testutils"
 	"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
+	"github.com/cockroachdb/cockroach/pkg/testutils/skip"
 	"github.com/cockroachdb/cockroach/pkg/util/leaktest"
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/timeutil"
@@ -37,6 +38,12 @@ import (
 func TestTelemetrySQLStatsIndependence(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
+
+	// This test fails if the central reporting server from CRL
+	// breaks. It should be improved to customize the reporting URL and
+	// mock the registration collector with an in-memory server.
+	skip.WithIssue(t, 63851)
+
 	ctx := context.Background()
 	params, _ := tests.CreateTestServerParams()
 	s, sqlDB, _ := serverutils.StartServer(t, params)