firefox-devtools#2980 added lodash and underscore detection

andreicristianpetcu · Jun 8, 2017 · 96b5326 · 96b5326
1 parent dbb50fe
commit 96b5326
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 0 deletions.
diff --git a/assets/images/Svg.js b/assets/images/Svg.js
@@ -15,6 +15,8 @@ const svg = {
   folder: require("./folder.svg"),
   globe: require("./globe.svg"),
   jquery: require("./jquery.svg"),
+  underscore: require("./underscore.svg"),
+  lodash: require("./lodash.svg"),
   "magnifying-glass": require("./magnifying-glass.svg"),
   "arrow-up": require("./arrow-up.svg"),
   "arrow-down": require("./arrow-down.svg"),

diff --git a/assets/images/lodash.svg b/assets/images/lodash.svg
diff --git a/assets/images/underscore.svg b/assets/images/underscore.svg
diff --git a/src/utils/frame.js b/src/utils/frame.js
@@ -47,6 +47,14 @@ function isExtJs(frame) {
   return /\/ext-all[\.\-]/.test(getFrameUrl(frame));
 }
 
+function isUnderscore(frame) {
+  return getFrameUrl(frame).match(/underscore/i);
+}
+
+function isLodash(frame) {
+  return getFrameUrl(frame).match(/lodash/i);
+}
+
 export function getLibraryFromUrl(frame: Frame) {
   // @TODO each of these fns calls getFrameUrl, just call it once
   // (assuming there's not more complex logic to identify a lib)
@@ -82,6 +90,14 @@ export function getLibraryFromUrl(frame: Frame) {
   if (isExtJs(frame)) {
     return "ExtJS";
   }
+
+  if (isUnderscore(frame)) {
+    return "Underscore";
+  }
+
+  if (isLodash(frame)) {
+    return "Lodash";
+  }
 }
 
 const displayNameMap = {