Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #21 #23 and updated dependencies #24

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Fixed #21 #23 and updated dependencies #24

merged 5 commits into from
Nov 1, 2021

Conversation

MherZaqaryan
Copy link
Contributor

No description provided.

andrei1058
andrei1058 reviewed Nov 1, 2021
View reviewed changes
Copy link
Owner

@andrei1058 andrei1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is good practice to close the sql lite connection since we may have many transactions on a medium player base and may result in useless cpu usage for try-closing every single time.

bedwars-plugin/src/main/java/com/andrei1058/bedwars/database/MySQL.java Outdated Show resolved Hide resolved
@andrei1058 andrei1058 merged commit c39458d into andrei1058:master Nov 1, 2021
@andrei1058 andrei1058 mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei1058 andrei1058 andrei1058 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MherZaqaryan @andrei1058