Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ArenaUtil isPlaying #157

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix ArenaUtil isPlaying #157

merged 1 commit into from
Dec 3, 2021

Conversation

dhiepp
Copy link
Contributor

@dhiepp dhiepp commented Dec 2, 2021

a simple fix in the API

ajgeiss0702
ajgeiss0702 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@ajgeiss0702 ajgeiss0702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have described what it fixed instead of just saying it fixed something, but yes.

Before, this method would have returned true even if the player wasnt player (a spectator) which doesn't seem to be ideal (since there is also isSpectating)

@dhiepp
Copy link
Contributor Author

dhiepp commented Dec 3, 2021

sorry, I thought it was a quick fix and just want to get it posted :p will be more detailed next time

@andrei1058 andrei1058 merged commit b31ee17 into andrei1058:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgeiss0702 ajgeiss0702 ajgeiss0702 approved these changes

@andrei1058 andrei1058 andrei1058 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiepp @ajgeiss0702 @andrei1058