Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear arrows from player's body on death (FIXED) #151

Merged
merged 10 commits into from
Dec 19, 2021

Conversation

CoachYT1
Copy link
Contributor

No description provided.

@andrei1058 andrei1058 added the needs-testing Pull requests which need manual testing. label Dec 1, 2021
@andrei1058
Copy link
Owner

Did you even import CraftPlayer? I don't think this will work with all version...

@ajgeiss0702
Copy link
Collaborator

It looks like CraftPlayer was already imported from other things. It compiles (as you can see in the checks).

I would also like to see that it works on all versions.

@andrei1058
Copy link
Owner

can someone test this on 1.12 and 1.13 or newer?

@andrei1058 andrei1058 added the help-wanted Help wanted issues - issues which should be a bit more involved than beginner issues. label Dec 3, 2021
@CoachYT1 CoachYT1 marked this pull request as draft December 6, 2021 15:33
@CoachYT1 CoachYT1 marked this pull request as ready for review December 16, 2021 10:56
@CoachYT1
Copy link
Contributor Author

Tested with 1.8.8, 1.9.4, 1.12.2, 1.15.2, 1.16.5

@andrei1058 andrei1058 self-requested a review December 17, 2021 22:07
Copy link
Owner

@andrei1058 andrei1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align with master. 1.18 support has been added

@andrei1058 andrei1058 removed the help-wanted Help wanted issues - issues which should be a bit more involved than beginner issues. label Dec 17, 2021
@andrei1058 andrei1058 merged commit f0cc14b into andrei1058:master Dec 19, 2021
@CoachYT1 CoachYT1 deleted the clear-arrows-from-body branch December 19, 2021 19:10
dhiepp pushed a commit to dhiepp/BedWars1058 that referenced this pull request Jul 15, 2022
* Clear arrows from player's body

(cherry picked from commit f0cc14b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-testing Pull requests which need manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants