Upgrades placeholders & lore messages are incorrect (or works not as it expected to) #668
Labels
bug
Something isn't working
Comments
|
I had this problem initially, but I don't really remember if it was the price, or the fact that it shows the wrong level, or like, I buy the last upgrade, and there's still one more in there (being that there are only 4) A solution I did for this was to turn the level 1 into 0, 2 into 1, 3 into 2, and 4 into 3, but only in the lang, I also removed the {cost} leaving only the value there. It can be a bit of work if you intend to use multi langs |
|
@tomkeuper is working on it |
tomkeuper
added a commit
that referenced
this issue
Feb 18, 2023
Merged
andrei1058
added a commit
that referenced
this issue
Feb 26, 2023
New features:
- Added {prefix} support to all messages
- Added unformatted player names for kill and bed destroy message
- Added unbreakable to mellee weapons #245
- Addded Elytra auto equip #663
- add toggle for halloween special (#632)
- Added Placeholders to upgrade message #668
For developers:
- add sidebar init event
- exposed sidebar to the API
- fix team identifier length (Sidebar kick issue (#682, #666 )
- Fix Moneys reward team-support on Solo & update variables names
- Bug fixes and placeholder adjustments (#685)
- Fixed command error when lobby location is not set
- Fixed spanish translation error #599
- Fixed spanish translation error #599
- Netherite armor support in 1.16+ #657
- Wins placeholder not in lobby sidebar #658
- Sidebar Title animation not working #660
- Player levels showing numbers #661
- Fixed In-game arena Scoreboard lines in the wrong spot #662
- NPE when clicking outside of shop inventory #664
- Added Placeholders to upgrade message #668
- Fixed players can collect drops during respawn #669
---------
Co-authored-by: Tom Keuper <[email protected]>
Co-authored-by: Yuri <[email protected]>
|
Closed as implented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In a localisation file (f.e.
messages_en.yml) theupgrades-upgrade-lore-forge-tier-1placeholders are set in the incorrect places, AND the placeholders logic there is not quite perfect.First of all, the
{cost}and{currency}placeholders should be on the level of the tier that you are buying.upgrades-upgrade-lore-forge-tier-1- correctupgrades-upgrade-lore-forge-tier-2nd, 3rd and 4th - incorrectBut the main thing: the cost of upgrades is hardcoded right now.
Mr. Ceasar once said:
*in discord
Screenshots
https://cdn.discordapp.com/attachments/348088106546757653/1074349862302265465/image.png
Plugin version: v23.1.1
The text was updated successfully, but these errors were encountered: