Abstract types: Update interface list #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas
reviewed
Jul 5, 2018
andreas
reviewed
Jul 5, 2018
graphql/src/graphql_schema.ml
Outdated
| @@ -391,6 +391,9 @@ module Make(Io : IO) = struct | |||
| | Abstract a -> | |||
| (* TODO add subtype check here *) | |||
| a.types <- (AnyTyp typ)::a.types; | |||
| (match (a, typ) with | |||
| | ({ kind= `Interface _; _}, Object o) -> o.interfaces := a :: !(o.interfaces) | |||
| | _ -> ()); | |||
There was a problem hiding this comment.
How about matching on both abstract_typ and typ in the outer match?
match abstract_typ, typ with
| Abstract ({ kind = `Interface _; _ } as a), Object o ->
(* TODO add subtype check here *)
a.types <- (AnyTyp typ)::a.types;
o.interfaces := a :: !o.interfaces
| Abstract ({ kind = `Union; _ } as a), Object o ->
a.types <- (AnyTyp typ)::a.types
| _ ->
failwith "..."
ozanmakes
force-pushed
the
update_abstract_type_interfaces
branch
from
cc1b876 to
1599a18
Compare
ozanmakes
force-pushed
the
update_abstract_type_interfaces
branch
from
1599a18 to
70c3a7f
Compare
|
@andreas done! I added a test checking the introspection query result for both unions and interfaces. Let me know if you had something more specific in mind. |
andreas
force-pushed
the
abstract-types
branch
2 times, most recently
from
fc83b7c to
8617819
Compare
andreas
force-pushed
the
abstract-types
branch
2 times, most recently
from
026ebea to
013bfc6
Compare
|
Thanks for the test case! I ended up rolling these changes into #70 and adapted them slightly to fix another issue. I appreciate the contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, GraphiQL can list implementations of interfaces: