wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACE…

…D task wake_up_process() should never wakeup a TASK_STOPPED/TRACED task. Change it to use TASK_NORMAL and add the WARN_ON(). TASK_ALL has no other users, probably can be killed. Signed-off-by: Oleg Nesterov <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
andreamerello · Jan 22, 2013 · 9067ac8 · 9067ac8
1 parent 9899d11
commit 9067ac8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
@@ -1523,7 +1523,8 @@ static void try_to_wake_up_local(struct task_struct *p)
  */
 int wake_up_process(struct task_struct *p)
 {
-	return try_to_wake_up(p, TASK_ALL, 0);
+	WARN_ON(task_is_stopped_or_traced(p));
+	return try_to_wake_up(p, TASK_NORMAL, 0);
 }
 EXPORT_SYMBOL(wake_up_process);