Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace old mock by the new unittest.mock #331

Closed
wants to merge 1 commit into from

Conversation

a-detiste
Copy link

No description provided.

@andreafrancia
Copy link
Owner

Thank you for your contribution but I'm still using the old mock library to keep trash-cli compatible with python 2.7

@a-detiste
Copy link
Author

a-detiste commented Mar 28, 2024 via email

@andreafrancia
Copy link
Owner

Yes, but this code should be put in single place.
We already have code like this:

from trashcli.compat import Protocol

If you want can make it works also for Mock and call, something like

from trashcli.compat import Mock
from trashcli.compat import call

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants