Draft: Achild/http connection #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreachild
force-pushed
the
achild/httpConnection
branch
from
a78c73a to
56151e3
Compare
… web socket connections to short lived http connections: -sped up obtaining a new connection by removing method-level synchronization of getAvailableConnection and introducing a separate set for available connections -introduced cleanup of idle connections to release resources -removed minSize since idle connections are now cleaned up and the pool can become empty if there is no traffic -increased maxSize default to 128 -increased core pool size of ScheduledThreadPoolExecutor that is used for creating new connections to number of available processors -added logging to help troubleshoot connection related integration tests failures
andreachild
force-pushed
the
achild/httpConnection
branch
from
7277d91 to
e87d22f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed connection pooling to reflect having switched from long lived web socket connections to short lived http connections:
getAvailableConnectionand introducing a separate set for available connectionsminSizesince idle connections are now cleaned up and the pool can become empty if there is no trafficmaxSizedefault to 500ScheduledThreadPoolExecutorthat is used for creating new connections to default 20 and introduce configuration setting to modify