Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't think it makes any sence to support pre-honeycomb code while … #147

Merged

Conversation

dryganets
Copy link
Contributor

…react-native minimum API level is 16. It causes side effects for us in production

…react-native minimum API level is 16. It causes side effects for us in production
@dryganets
Copy link
Contributor Author

We have evidence that pre-honey comb support code works in production (and hides real problems causing artificial crashes for us).
I think as react minimum supported android version is 16 it doesn't make sense to continue the support of this code.

@dryganets
Copy link
Contributor Author

Cross-link just for the reference:
sqlcipher/android-database-sqlcipher#329

@andpor andpor merged commit be972ed into andpor:master Apr 15, 2017
@andpor
Copy link
Owner

andpor commented Apr 15, 2017

I agree Sergey - this is no longer needed particularly if it causes issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants