-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All statements and queries are closed in finally statements #132
All statements and queries are closed in finally statements #132
Conversation
…to fix SQLiteCipher corner case crashes
} catch (IOException ignored) { | ||
} | ||
} | ||
closeQuietly(in); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this!
Excellent - all these make common sense. This cleanup was overdue. Great work Sergei! Do you have any more PR coming? |
This is all I have for now. |
@dryganets Sergey - if it is a small diff maybe it would make sense to incorporate it somehow to this module...I would have no objections actually..can you suggest something? |
Well, the problem is not in the Dependency size, but in the library size. If you don't need encryption you don't want to have an extra mb to your apk. We need to make a plugin model for Android with default implementation using system library. |
Also see #40 (comment):
|
According to @brodybits arguments: can we leave this optional per #ifdef direction on objC-Side and something similar on android? |
I have to think about this. @brodybits touches on import/export compliance which is quite important... |
SQLiteCipher crashes/hangs in cases when you don't close prepared statements correctly.
In this commit, I'm moving all cursors close statements inside of finally block.
Also missing close statements are added.