Upgrade ts_rs #76
Merged
Upgrade ts_rs #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge thanks for tackling this! I'll give it a proper review once I've had a chance to wrap my head around ts-rs v9, but I see no major issues at all glance. |
Merged
andogq
added a commit
that referenced
this pull request
Aug 12, 2024
# Version Updates Merging this PR will release new versions of the following packages based on your change files. # qubit ## [0.10.0] ### feat - 7fe1372 Add `/* eslint-disable */` to generated bindings (#77, thanks @lucasavila00!) - 7fe1372 Upgrade `ts-rs` to latest version (#76, thanks @lucasavila00!)
|
This worked out to be a very straight forward upgrade, thank you for taking the time to send it through! It's now been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
I'm still getting used to Qubit's codebase. I'm unsure if this is correct, but it matches the v8 behavior on all current tests.