fix

andiwand · Mar 19, 2024 · d4b74e4 · d4b74e4
1 parent 182feb3
commit d4b74e4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ProtoTrackTruthMatcher.cpp b/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ProtoTrackTruthMatcher.cpp
@@ -98,10 +98,10 @@ ActsExamples::ProcessCode ProtoTrackTruthMatcher::execute(
     // Check if the trajectory is matched with truth.
     // If not, it will be classified as 'fake'
     const bool recoMatched =
-        static_cast<float>(nMajorityHits) / protoTrack.size() >=
+        static_cast<double>(nMajorityHits) / protoTrack.size() >=
         m_cfg.matchingRatio;
     const bool truthMatched =
-        static_cast<float>(nMajorityHits) /
+        static_cast<double>(nMajorityHits) /
             particleTruthHitCount.at(majorityParticleId) >=
         m_cfg.matchingRatio;
 

diff --git a/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp b/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp
@@ -78,7 +78,7 @@ ActsExamples::ProcessCode TrackTruthMatcher::execute(
     }
 
     // Get the majority particleId and majority particle counts
-    // Note that the majority particle might be not in the truth seeds
+    // Note that the majority particle might not be in the truth seeds
     // collection
     ActsFatras::Barcode majorityParticleId =
         particleHitCounts.front().particleId;

diff --git a/Examples/Io/Performance/ActsExamples/Io/Performance/TrackFinderPerformanceWriter.cpp b/Examples/Io/Performance/ActsExamples/Io/Performance/TrackFinderPerformanceWriter.cpp
@@ -184,26 +184,25 @@ struct ActsExamples::TrackFinderPerformanceWriter::Impl {
         }
         const auto& particleMatch = imatched->second;
 
-        // Get the barcode of the majority truth particle
-        SimBarcode majorityParticleId = particleMatch.particle.value();
+        if (particleMatch.particle.has_value()) {
+          SimBarcode majorityParticleId = particleMatch.particle.value();
 
-        if (!particleMatch.contributingParticles.empty()) {
           auto it = majorityCount.try_emplace(majorityParticleId, 0u).first;
           it->second += 1;
+
+          // Find the truth particle via the barcode
+          if (auto ip = particles.find(majorityParticleId);
+              ip == particles.end()) {
+            ACTS_WARNING(
+                "Majority particle not found in the particles collection.");
+          }
         }
+
         for (const auto& hc : particleMatch.contributingParticles) {
           auto it = reconCount.try_emplace(hc.particleId, 0u).first;
           it->second += 1;
         }
 
-        // Find the truth particle via the barcode
-        if (auto ip = particles.find(majorityParticleId);
-            ip == particles.end()) {
-          ACTS_WARNING(
-              "Majority particle not found in the particles collection.");
-          continue;
-        }
-
         trkEventId = eventId;
         trkTrackId = itrack;
         trkNumHits = track.size();