[BUGFIX] Append slash to folder identifiers #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the problem that fetching a folder via API
and using that to upload a file put the file into the wrong folder:
$folder = $storage->getFolder('myfolder');
$storage->addFile('/tmp/file.txt', $folder, 'file.txt');
//created "/myfolderfile.txt" instead of "/myfolder/file.txt"
TYPO3's own
`AbstractHierarchicalFilesystemDriver::canonicalizeAndCheckFolderIdentifier`
appends slashes,
and our `createFolder()` already returned identifiers with slashes at the end.
Resolves: andersundsehr#146
cweiske
force-pushed
the
folder-identifier-slash
branch
from
a4e5c77
to
1bb56ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem that fetching a folder via API and using that to upload a file put the file into the wrong folder:
TYPO3's own
AbstractHierarchicalFilesystemDriver::canonicalizeAndCheckFolderIdentifierappends slashes,and our
createFolder()already returned identifiers with slashes at the end.Resolves: #146