Implement message merging #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Required/Optional in deserialization - re-introduce a basic_opt type to be more explicit about presense of default values
andersfugmann
force-pushed
the
andersfugmann/merge_messages
branch
from
e7f9867
to
9140a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec, if a single field message is received twice in a message the two messages should be merged recursively.
The PR implement this functionality.
Tests has been added and the test lib has been extended to verify parsing of multiple message fields as well as verifying full (slow) deserialization by injecting an out of order field at the head of the input buffer (reader)
While developing, a bug handling proto2 required message fields were also identified and fixed.