Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: infinite recursion in TronGrid client #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbalashovv
Copy link
Contributor

@mbalashovv mbalashovv commented Nov 1, 2024

There was infinite recursion in HTTP provider because of condition

if len(self._api_keys) > 1:

not making self._api_keys list be empty. That's why random.choice(self._api_keys) always had elements to get for making requests

@andelf

@mbalashovv mbalashovv closed this Nov 1, 2024
@MrNaif2018
Copy link
Collaborator

Hi, why did you close the PR?

@mbalashovv mbalashovv reopened this Nov 22, 2024
@mbalashovv
Copy link
Contributor Author

My mistake. I reopened it

@mbalashovv
Copy link
Contributor Author

Please consider to look at this
@andelf @MrNaif2018

Copy link
Owner

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Better use another error type.

@mbalashovv
Copy link
Contributor Author

We can use the existing UnknownError or create a new error something like CredentialsError, which can be used for API services but not for nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants